Integrate external project zlib, libxml2 and sundials build into main cmake build #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benstone Zhang <[email protected]>
…8, because of sundials v7.1.1 requirements. Signed-off-by: Benstone Zhang <[email protected]>
benstonezhang
force-pushed
the
main
branch
2 times, most recently
from
6ca7360 to
13793d3
Compare
benstonezhang
changed the title
…ig for external libs Signed-off-by: Benstone Zhang <[email protected]>
beutlich
reviewed
Mar 30, 2025
build/external.cmake
Outdated
| xml2_src | ||
| PREFIX ${EXTERNAL_BASE_DIR} | ||
| GIT_REPOSITORY https://github.com/GNOME/libxml2.git | ||
| GIT_TAG 60d3056c97067e6cb2125284878ed7c99c90ed81 # v2.13.4 |
There was a problem hiding this comment.
Suggested change
| GIT_TAG 60d3056c97067e6cb2125284878ed7c99c90ed81 # v2.13.4 | |
| GIT_TAG v2.13.4 |
There was a problem hiding this comment.
Per cmake document ExternalProject, commit hash should be preferred than tag.
Anyway, if you really want tag, I will update it.
build/external.cmake
Outdated
| zlib_src | ||
| PREFIX ${EXTERNAL_BASE_DIR} | ||
| GIT_REPOSITORY https://github.com/madler/zlib.git | ||
| GIT_TAG 51b7f2abdade71cd9bb0e7a373ef2610ec6f9daf # v1.3.1 |
There was a problem hiding this comment.
Suggested change
| GIT_TAG 51b7f2abdade71cd9bb0e7a373ef2610ec6f9daf # v1.3.1 | |
| GIT_TAG v1.3.1 |
build/external.cmake
Outdated
| cvcode_src | ||
| PREFIX ${EXTERNAL_BASE_DIR} | ||
| GIT_REPOSITORY https://github.com/LLNL/sundials.git | ||
| GIT_TAG c28eaa3764a03705d61decb6025b409360e9d53f # v7.1.1 |
There was a problem hiding this comment.
Suggested change
| GIT_TAG c28eaa3764a03705d61decb6025b409360e9d53f # v7.1.1 | |
| GIT_TAG v7.1.1 |
Signed-off-by: Benstone Zhang <[email protected]>
Signed-off-by: Benstone Zhang <[email protected]>
|
by the way, we can generate and build all on linux and macOS by cmake with command:
|
Signed-off-by: Benstone Zhang <[email protected]>
…issue on windows platform Signed-off-by: Benstone Zhang <[email protected]>
Signed-off-by: Benstone Zhang <[email protected]>
Signed-off-by: Benstone Zhang <[email protected]>
Signed-off-by: Benstone Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to run separate build python script anymore, all within cmake